[15.0] [ADD] sale_order_restrict_copy_archived_product#3884
Conversation
01a7efc to
a10832a
Compare
ValentinVinagre
left a comment
There was a problem hiding this comment.
don't put plurals in names
a10832a to
ec23dc0
Compare
I have renamed the module name |
|
@Tisho99 pre-commit |
ec23dc0 to
f6cc451
Compare
@ValentinVinagre I have fixed the precommit |
|
This PR has the |
HaraldPanten
left a comment
There was a problem hiding this comment.
Just some comments and It'll be ready form me. THX!
sale_order_restrict_copy_archived_product/readme/DESCRIPTION.md
Outdated
Show resolved
Hide resolved
|
@Tisho99 Thanks for this. My question: isn't it a little bit to harsh to restrict copy of the whole sale order ? Maybe not copying those products in lines ? |
|
Hello @rousseldenis, thank you for your interest. We had considered allowing duplicate orders by omitting lines with archived products, but we ruled it out because users might duplicate orders and not realize that some lines had been deleted. However, if the use case is important, we could add this option via company configuration, allowing duplicate orders and adding a note with the lines that could not be duplicated, for example in the chatter. |
f6cc451 to
10b9ed3
Compare
HaraldPanten
left a comment
There was a problem hiding this comment.
Waiting to merge after Denis's comments
|
This PR has the |
|
Exactly what @Tisho99 pointed out. We ruled it out due to the high likelihood of user error. Another option was to indicate in an internal note the products not transferred to the new sale... but we saw the same likelihood of errors. So we opted for this sole method; but it could easily be expanded. |
|
@rousseldenis Did you have the chance to check our comments? THX. |
|
Merging as we didn't receive any blocking feedback. This module can be improved in a future. /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 7b6888d. Thanks a lot for contributing to OCA. ❤️ |
This module allows you to restrict dulpication of sales order if they have archived products
T-8748