Skip to content

[15.0] [ADD] sale_order_restrict_copy_archived_product#3884

Merged
OCA-git-bot merged 1 commit intoOCA:15.0from
sygel-technology:15.0-add-sale_order_restrict_copy_archived_products
Sep 23, 2025
Merged

[15.0] [ADD] sale_order_restrict_copy_archived_product#3884
OCA-git-bot merged 1 commit intoOCA:15.0from
sygel-technology:15.0-add-sale_order_restrict_copy_archived_products

Conversation

@Tisho99
Copy link
Copy Markdown
Contributor

@Tisho99 Tisho99 commented Sep 5, 2025

This module allows you to restrict dulpication of sales order if they have archived products

T-8748

@Tisho99 Tisho99 changed the title [ADD] sale_order_restrict_copy_archived_products [15.0] [ADD] sale_order_restrict_copy_archived_products Sep 5, 2025
@Tisho99 Tisho99 force-pushed the 15.0-add-sale_order_restrict_copy_archived_products branch 3 times, most recently from 01a7efc to a10832a Compare September 5, 2025 10:23
Copy link
Copy Markdown

@sara-castello sara-castello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't put plurals in names

@Tisho99 Tisho99 changed the title [15.0] [ADD] sale_order_restrict_copy_archived_products [15.0] [ADD] sale_order_restrict_copy_archived_product Sep 10, 2025
@Tisho99 Tisho99 force-pushed the 15.0-add-sale_order_restrict_copy_archived_products branch from a10832a to ec23dc0 Compare September 10, 2025 15:27
@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Sep 10, 2025

don't put plurals in names

I have renamed the module name

@ValentinVinagre
Copy link
Copy Markdown
Contributor

@Tisho99 pre-commit

@Tisho99 Tisho99 force-pushed the 15.0-add-sale_order_restrict_copy_archived_products branch from ec23dc0 to f6cc451 Compare September 12, 2025 07:04
@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Sep 12, 2025

@Tisho99 pre-commit

@ValentinVinagre I have fixed the precommit

Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Copy Markdown
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments and It'll be ready form me. THX!

@rousseldenis
Copy link
Copy Markdown
Contributor

@Tisho99 Thanks for this. My question: isn't it a little bit to harsh to restrict copy of the whole sale order ? Maybe not copying those products in lines ?

@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Sep 15, 2025

Hello @rousseldenis, thank you for your interest.

We had considered allowing duplicate orders by omitting lines with archived products, but we ruled it out because users might duplicate orders and not realize that some lines had been deleted.

However, if the use case is important, we could add this option via company configuration, allowing duplicate orders and adding a note with the lines that could not be duplicated, for example in the chatter.

CC @ValentinVinagre

@Tisho99 Tisho99 force-pushed the 15.0-add-sale_order_restrict_copy_archived_products branch from f6cc451 to 10b9ed3 Compare September 15, 2025 13:56
Copy link
Copy Markdown
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to merge after Denis's comments

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ValentinVinagre
Copy link
Copy Markdown
Contributor

Exactly what @Tisho99 pointed out. We ruled it out due to the high likelihood of user error. Another option was to indicate in an internal note the products not transferred to the new sale... but we saw the same likelihood of errors. So we opted for this sole method; but it could easily be expanded.

@HaraldPanten
Copy link
Copy Markdown
Contributor

@rousseldenis Did you have the chance to check our comments?

THX.

@HaraldPanten
Copy link
Copy Markdown
Contributor

Merging as we didn't receive any blocking feedback. This module can be improved in a future.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-3884-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 51b4780 into OCA:15.0 Sep 23, 2025
11 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7b6888d. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 15.0-add-sale_order_restrict_copy_archived_products branch September 23, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants